Merge pull request #67 from texttechne/master

Reset console spy before each test to make tests more robust
AlexGilleran · Jul 17, 2017 · 823bcc9 · 823bcc9
2 parents d5f0a51 + e2198f1
commit 823bcc9
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/spec/test/choose.js b/spec/test/choose.js
@@ -55,7 +55,11 @@ describe("requiring in component with choose/otherwise", function() {
 
 describe("requiring in component with nested choose", function() {
   var Fixture = require("../fixtures/choose/nested-choose.jsx");
-  var consoleSpy = chai.spy.on(console, "error");
+  var consoleSpy;
+
+  beforeEach(function() {
+    consoleSpy = chai.spy.on(console, "error");
+  });
 
   it("should render when-when block when both conditions true", function() {
     var rendered = util.render(Fixture, {outerWhen: true, innerWhen: true});
@@ -87,7 +91,11 @@ describe("requiring in component with nested choose and a key (issue #52)", func
   // runs probably means it's OK but we'll do a proper test because why not.
 
   var Fixture = require("../fixtures/choose/nested-choose-no-inner-component.jsx");
-  var consoleSpy = chai.spy.on(console, "error");
+  var consoleSpy;
+
+  beforeEach(function() {
+    consoleSpy = chai.spy.on(console, "error");
+  });
 
   it("should render when-when block when both conditions true", function() {
     var rendered = util.render(Fixture, {outerWhen: true, innerWhen: true});

diff --git a/spec/test/extension.js b/spec/test/extension.js
@@ -49,7 +49,11 @@ describe("extension: multiple children", function() {
   var FixtureChoose = require("../fixtures/extension/choose-with-multiple-children.jsx");
   var FixtureFor = require("../fixtures/extension/for-with-multiple-children.jsx");
 
-  var consoleSpy = chai.spy.on(console, "error");
+  var consoleSpy;
+
+  beforeEach(function() {
+    consoleSpy = chai.spy.on(console, "error");
+  });
 
 
   it("should allow for multiple children within <If>", function() {

diff --git a/spec/test/if.js b/spec/test/if.js
@@ -52,7 +52,11 @@ describe("requiring in component with if/else", function() {
 
 describe("requiring in component with nested if/else", function() {
   var Fixture = require("../fixtures/if/nested-if.jsx");
-  var consoleSpy = chai.spy.on(console, "error");
+  var consoleSpy;
+
+  beforeEach(function() {
+    consoleSpy = chai.spy.on(console, "error");
+  });
 
   it("should render if-if block when both conditions true", function() {
     var rendered = util.render(Fixture, {ifCondition: true, nestedIfCondition: true});