-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usage of lodash #33
Comments
Is the weight of it that much of a problem? Keep in mind that the libraries included in JSX Control Statements don't actually get included in your app, so this will only affect the initial |
Someone was requesting instructions on how to use it with babel-standalone, which is a standalone build of Babel for use in non-Node.js environments (including browsers, but also projects like ReactJS.NET and ruby-babel-transpiler). If they wanted to use it in a client-side script for whatever reason (eg. a REPL, or site like JSBin/JSFiddle), it would require bundling lodash too, adding unnecessary weight 😃 IMO lodash isn't as useful as it once was, now that arrays have a bunch of functional methods on them, and using |
Ah yeah that makes sense, will look into it :). |
Fixed in master. Used lodash methods:
Only challenge was to replace the last method. Should be included in release 3.1.0. |
Nice! :) |
Done in v3.1.0 |
Lodash is only used a few times, and all the usages seem to be pretty simple use cases that could be replaced with native functions like Array.prototype.reduce and Array.prototype.forEach. There's no point adding the weight of the entire lodash library :)
The text was updated successfully, but these errors were encountered: