Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D pooling #17

Closed
protein27 opened this issue Nov 16, 2018 · 2 comments
Closed

3D pooling #17

protein27 opened this issue Nov 16, 2018 · 2 comments

Comments

@protein27
Copy link

protein27 commented Nov 16, 2018

self.g = nn.Sequential(self.g, max_pool(kernel_size=2))

In the paper, the pooling is only in the spatial domain. I think the kernel size is not set correctly when the input contains temporal dimension.

https://github.com/facebookresearch/video-nonlocal-net/blob/b273c446e8e10dbaec266520e4005d27d7052125/lib/models/nonlocal_helper.py#L40

@AlexHex7
Copy link
Owner

@protein27 Thanks for pointing it out! I will correct it when I have time.

@AlexHex7
Copy link
Owner

I have corrected the code .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants