Gpu #30
Merged
Gpu #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pu saveData to not write halo regions
…test update to new API
…lot that wasnt related to #26)
…dding MPI to build system
…raries. This is simpler than doing some compilation with mpicc and some with nvcc but does require the user knowing the location of their MPI build.
… Serial HDF5 also outputs flat files. Added HDF5 to CMAKE. Added scripts to convert flat file to HDF5, and to compare two arbitrary flat file output sets.
…un on CPU currently)
… wrong answer. Currently copying all prims and aux to gpu -- need to copy only those values that are required for the guess in future
…ridis being stored in the wrong folder
…ridis being stored in the wrong folder
Merged
IanHawke
reviewed
Mar 9, 2021
Scripts/IridisEnv/tests_job_gpu.sh
Outdated
|
|
||
| source ../../venv/bin/activate | ||
|
|
||
| export PYTHONPATH=$PYTHONPATH:../../Scripts:/home/amb1u19/METHOD_branches/METHOD_dev_hdf5/Scripts |
There was a problem hiding this comment.
You may want amb1u19 -> whoami or a similar trick
IanHawke
reviewed
Mar 9, 2021
Scripts/IridisEnv/tests_job_cpu.sh
Outdated
|
|
||
| source ../../venv/bin/activate | ||
|
|
||
| export PYTHONPATH=$PYTHONPATH:../../Scripts:/home/amb1u19/METHOD_branches/METHOD_dev_hdf5/Scripts |
There was a problem hiding this comment.
Same issue as GPU script - username hardcoded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing:
SRMHD was tested for the non-MPI case using the test_srmhd unit test. CPU and GPU versions are no longer compared, instead, certain non-MPI GPU simulation outputs are compared to MPI GPU when unit tests are run.
The checkpoint restart functionality has only been tested very simply -- by writing out an HDF5 file at t=0, and comparing a run initialised in the normal way with a run initialised using that HDF5 file. There are currently no plans to add checkpoint restart functionality into the unit tests.
My next goal for the GPU version is to convert the unit testing framework to use HDF5 rather than text outputs where outputs are saved. Happy to either wait on this PR to include that functionality or to make another PR.