Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I apologise for nothing #58

Merged
merged 3 commits into from
Oct 5, 2020
Merged

Conversation

TomGranot
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 5, 2020

Codecov Report

Merging #58 into master will decrease coverage by 92.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #58       +/-   ##
===========================================
- Coverage   100.00%   7.69%   -92.31%     
===========================================
  Files            1       1               
  Lines           13      13               
===========================================
- Hits            13       1       -12     
- Misses           0      12       +12     
Impacted Files Coverage Δ
index.js 7.69% <0.00%> (-92.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d93e2e2...edd1644. Read the comment docs.

puns.json Show resolved Hide resolved
Copy link
Owner

@AlexLakatos AlexLakatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made me laugh! Thanks for the PR! I've only got a minor request, it looks like you forgot a closing bracket.

@TomGranot
Copy link
Contributor Author

@AlexLakatos This is why no one should write JSON by hand. In a web interface. On a Monday.
Fixed.

puns.json Show resolved Hide resolved
@AlexLakatos
Copy link
Owner

Thanks for the PR & Happy Hacktoberfest!

@AlexLakatos AlexLakatos merged commit 560b1df into AlexLakatos:master Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants