Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust pickup AI logic #5189

Closed
wants to merge 6 commits into from
Closed

Adjust pickup AI logic #5189

wants to merge 6 commits into from

Conversation

SiverDX
Copy link
Contributor

@SiverDX SiverDX commented Feb 21, 2024

Added custom pickup goal, used by

  • pixie
  • hippogryph
  • myrmex worker
  • cockatrice
  • death worm
  • ampithere

should fix #5187

Additionally:

  • added logic to the previously empty add food effect method when dragons eat food (i.e. they should now gain the effects)
  • removed refreshDimensions in EntityMultiPart because it was causing multiple seconds of delay when joining and leaving worlds (dimensions should only be refreshed when needed, not in a tick method)
  • tried to adjust myrmex worker goal logic regarding storing items - didn't work (might be issue by the advanced pathfinding system since they simply don't move - they can see the cocoons and sometimes they get stuck at walls and move a bit once you break some blocks)
  • made the check (whether a myrmex is inside a hive) more simple

+ fix hardcoded item references for pixie
@SiverDX
Copy link
Contributor Author

SiverDX commented Feb 22, 2024

now that I think about it

the game time % 4 logic should just be replaced with an internal tick tracker

I think someone else already mentioned it but the tick method of the goal ticks every 2 ticks

so if you're unlucky you get no updates (that's what the force new is there for atm)

will adjust that

@TheBv TheBv linked an issue Feb 22, 2024 that may be closed by this pull request
2 tasks
@TheBv TheBv added this to To-Do in 2.1.13-beta-4/5 Feb 22, 2024
@TheBv TheBv moved this from To-Do to In-Progress in 2.1.13-beta-4/5 Feb 22, 2024
+ adjust pixie
+ adjust hippogryph
+ adjust myrmex worker
@SiverDX
Copy link
Contributor Author

SiverDX commented Feb 22, 2024

(need to still adjust some other goals to use this custom one)

@TheBv TheBv marked this pull request as draft February 22, 2024 09:46
+ cockatrice
+ death worm
+ ampithere
+ myrmex worker
- apply food effects to dragons
- removed refreshdimension call from enttiymultipart (caused world join and leave delay of multiple seconds)
- simplified hive check
- tried to adjust store goal but myrmex still won't move
@SiverDX
Copy link
Contributor Author

SiverDX commented Feb 22, 2024

Tried it out with pixie and death worm and both did what they were supposed to in regards to picking up items

@Loonarin-San
Copy link

Loonarin-San commented Feb 22, 2024

Sooooo does this mean I'm just unlucky or do I need to chase those pixies around with cake items until they decide to eat

@SiverDX SiverDX marked this pull request as ready for review March 15, 2024 09:06
@SiverDX SiverDX closed this by deleting the head repository Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
2.1.13-beta-4/5
In-Progress
Development

Successfully merging this pull request may close these issues.

Pixie's won't pick up cake
2 participants