Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for composer create-project #161

Closed
wants to merge 46 commits into from

Conversation

tannguyen04
Copy link
Collaborator

@tannguyen04 tannguyen04 commented May 9, 2024

Checklist before requesting a review

closes #160

  • I have formatted the subject to include ticket number as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

Copy link

github-actions bot commented May 9, 2024

@github-actions github-actions bot temporarily deployed to pull request May 9, 2024 03:13 Inactive
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.22%. Comparing base (549a63d) to head (22e2318).
Report is 1 commits behind head on 1.x.

Additional details and impacted files
@@             Coverage Diff             @@
##              1.x     #161       +/-   ##
===========================================
- Coverage   77.06%   22.22%   -54.84%     
===========================================
  Files           8        2        -6     
  Lines         449       27      -422     
===========================================
- Hits          346        6      -340     
+ Misses        103       21       -82     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request May 9, 2024 04:30 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2024 07:05 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 9, 2024 09:56 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 10, 2024 02:28 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 10, 2024 02:44 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 10, 2024 03:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 10, 2024 05:23 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 08:27 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 08:34 Inactive
@@ -53,24 +53,25 @@ jobs:
sudo chown "$USER" /usr/local/bin/ahoy && chmod +x /usr/local/bin/ahoy

- name: Install dependencies
run: npm ci
working-directory: .scaffold/tests
run: composer install
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not do this. The whole point was to hide all the scaffold stuff inside of the .scaffold dir so that the consumers can see a clean structure with just one odd directory .scaffold.

Please revert this back and any other overrides.

The task was to only update a couple of fields in composer.json and store everything in .scaffold.

@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 16:40 Inactive
@tannguyen04 tannguyen04 changed the title Init. Added support for composer create-project May 13, 2024
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 16:51 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 17:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 17:06 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 13, 2024 17:08 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 14, 2024 02:19 Inactive
@AlexSkrypnyk AlexSkrypnyk deleted the feature/support-composer-create-project branch May 26, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for composer create-project
2 participants