Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#26] Update tests to use CommandTestCase and update coverage #32

Merged
merged 6 commits into from
Jan 3, 2024
Merged

[#26] Update tests to use CommandTestCase and update coverage #32

merged 6 commits into from
Jan 3, 2024

Conversation

tannguyen04
Copy link
Collaborator

@tannguyen04 tannguyen04 commented Jan 3, 2024

closes #26

Checklist before requesting a review

  • I have formatted the subject to include ticket number
    as [#-123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

  • Need to update tests to use CommandTester
  • Also, need to update the tests's namespace to follow namespace YourNamespace\App\Tests\Unit\Command
  • And also need to move the command into src/Command dir.

Screenshots

@codecov-commenter
Copy link

codecov-commenter commented Jan 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (539d87f) 29.40% compared to head (f0119bb) 30.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   29.40%   30.00%   +0.59%     
==========================================
  Files          23       23              
  Lines         551      550       -1     
==========================================
+ Hits          162      165       +3     
+ Misses        389      385       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tannguyen04 tannguyen04 marked this pull request as ready for review January 3, 2024 06:00
@AlexSkrypnyk AlexSkrypnyk merged commit 3f17d39 into AlexSkrypnyk:main Jan 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tests to use CommandTestCase and update coverage
3 participants