-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#3] Added Dockerfile to allow running as a container #48
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
=======================================
Coverage 98.62% 98.62%
=======================================
Files 24 24
Lines 653 653
=======================================
Hits 644 644
Misses 9 9 ☔ View full report in Codecov by Sentry. |
Hi @AlexSkrypnyk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tannguyen04
thank you for working on this
These are the changes that need to take place:
-
Rename the
ci.yml
totest-docker.yml
and rename thename
to be consistent withtest-php.yml
. Also use trigger events from https://github.com/AlexSkrypnyk/scaffold/blob/main/.github/workflows/test-php.yml#L3 -
Add matrix for Docker versions 23, 24, 25 (as per https://endoflife.date/docker-engine)
-
Remove the deployment step completely - the deployment will be setup to take place automatically via webhook in DockerHub
-
Add this section to the
README.md
https://github.com/drevops/ci-runner?tab=readme-ov-file#maintenance-and-releasing
- Update README with versioning & releasing. - Remove deploy step.
Hi @AlexSkrypnyk Thanks. |
Checklist before requesting a review
closes #3
as
[#123] Verb in past tense with dot at the end.
Changed
section about WHY something wasdone if this was not a normal implementation
they passed
Changed
Screenshots