Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3] Added Dockerfile to allow running as a container #48

Merged
merged 18 commits into from
Feb 5, 2024

Conversation

tannguyen04
Copy link
Collaborator

@tannguyen04 tannguyen04 commented Jan 29, 2024

Checklist before requesting a review

closes #3

  • I have formatted the subject to include ticket number
    as [#123] Verb in past tense with dot at the end.
  • I have added a link to the issue tracker
  • I have provided information in Changed section about WHY something was
    done if this was not a normal implementation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have run new and existing relevant tests locally with my changes, and
    they passed
  • I have provided screenshots, where applicable

Changed

Screenshots

Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bc586de) 98.62% compared to head (3cbebae) 98.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          24       24           
  Lines         653      653           
=======================================
  Hits          644      644           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tannguyen04 tannguyen04 marked this pull request as ready for review February 3, 2024 08:17
@tannguyen04
Copy link
Collaborator Author

Hi @AlexSkrypnyk
One note is. If we release a tag via Github UI, CI will be triggered. Ci will not be triggered by Github release action.

Copy link
Owner

@AlexSkrypnyk AlexSkrypnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tannguyen04
thank you for working on this

These are the changes that need to take place:

  1. Rename the ci.yml to test-docker.yml and rename the name to be consistent with test-php.yml. Also use trigger events from https://github.com/AlexSkrypnyk/scaffold/blob/main/.github/workflows/test-php.yml#L3

  2. Add matrix for Docker versions 23, 24, 25 (as per https://endoflife.date/docker-engine)

  3. Remove the deployment step completely - the deployment will be setup to take place automatically via webhook in DockerHub

  4. Add this section to the README.md https://github.com/drevops/ci-runner?tab=readme-ov-file#maintenance-and-releasing

@AlexSkrypnyk AlexSkrypnyk added the enhancement New feature or request label Feb 5, 2024
- Update README with versioning & releasing.
- Remove deploy step.
@tannguyen04
Copy link
Collaborator Author

Hi @AlexSkrypnyk
I have updated the PR as your comment.
Could you please double check ?

Thanks.

@AlexSkrypnyk AlexSkrypnyk merged commit bb77ca9 into main Feb 5, 2024
9 checks passed
@AlexSkrypnyk AlexSkrypnyk deleted the feature/allow-run-as-container branch February 5, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dockerfile to allow running as a container
2 participants