Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the :focus on the menubar menu button class to fix styling #233

Merged
merged 1 commit into from
Aug 5, 2023
Merged

Remove the :focus on the menubar menu button class to fix styling #233

merged 1 commit into from
Aug 5, 2023

Conversation

mikeseese
Copy link
Contributor

This PR fixes #225 by removing the unnecessary :focus CSS selector. I only tested this on Windows.

Before this PR:

electron-titlebar-before

After this PR:

electron-titlebar-after

@AlexTorresDev AlexTorresDev merged commit a0afc79 into AlexTorresDev:main Aug 5, 2023
2 checks passed
@mikeseese mikeseese deleted the fix/incorrect-hover-css branch August 5, 2023 03:46
@AlexTorresDev
Copy link
Owner

🎉 This PR is included in version 4.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@AlexTorresDev AlexTorresDev added the released Release a new version using CI label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Release a new version using CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Windows] Hovering menu two options are highlighted
2 participants
@mikeseese @AlexTorresDev