Upgrade rubocop to version 0.84.0

[depfu]

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 0.83.0 → ~> 0.84.0) · Repo · Changelog

Release Notes

0.84.0

New features

• #7735: NodePattern and AST classes have been moved to the rubocop-ast gem. (@marcandre)
• #7950: Add new Lint/DeprecatedOpenSSLConstant cop. (@bdewater)
• #7976: Add AllowAliasSyntax and AllowedMethods options for Layout/EmptyLinesAroundAttributeAccessor. (@koic)
• #7984: New rake task "check_commit" will run rspec and rubocop on files touched by the last commit. (@marcandre)

Bug fixes

• #7953: Fix an error for Lint/AmbiguousOperator when a method with no arguments is used in advance. (@koic)
• #7962: Fix a false positive for Lint/ParenthesesAsGroupedExpression when heredoc has a space between the same string as the method name and (. (@koic)
• #7967: Style/SlicingWithRange cop now supports any expression as its first index. (@zverok)
• #7972: Fix an incorrect autocrrect for Style/HashSyntax when using a return value uses return. (@koic)
• #7886: Fix a bug in AllowComments logic in Lint/SuppressedException. (@jonas054)
• #7991: Fix an error for Layout/EmptyLinesAroundAttributeAccessor when attribute method is method chained. (@koic)
• #7993: Fix a false positive for Migration/DepartmentName when a disable comment contains an unexpected character for department name. (@koic)

Changes

• #7952: (Breaking) Change the max line length of Layout/LineLength to 120 by default. (@koic)
• #7959: Change enforced style to conditionals for Style/AndOr. (@koic)
• #7985: Add EnforcedStyle for Style/DoubleNegation cop and allow double nagation in contexts that use boolean as a return value. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 50 commits:

• Fix the release notes
• Cut 0.84
• Add doc for disabling comment style
• [Fix #7993] Fix a false positive for `Migration/DepartmentName`
• Add a .dir-locals.el
• Remove unneeded let for specs using :config shared environment
• Refactor `config` shared context. Simplify some specs.
• Spec: remove trailing whitespace
• Lint/SuppressedException: Explicit AllowComments config in spec
• Lint/EmptyWhen Add explicit config that is differing from default [#7999]
• Add rake check_commit and check_commit:auto_correct
• Allow args in SpecRunner task
• [Fix #7991] Fix an error for `Layout/EmptyLinesAroundAttributeAccessor`
• [Fix #7886] Look for comments between rescue and end
• [Docs] Improve a bit the structure of the cop development docs
• [Docs] Improve the automated code reviews section
• [Docs] Replace mentions of Salt with GitHub Sponsors
• [Docs] Extend the explanation of --safe-auto-correct
• Fix a typo
• Tweak a changelog entry
• Fix option names in the changelog
• Fix the broken docs build
• Add `EnforcedStyle` for `Style/DoubleNegation` cop
• [Fix #7976] Add ignore options for `Layout/EmptyLinesAroundAttributeAccessor`
• [Docs] Improve some wording in the "Development" section of the docs
• [Docs] Update some references to reflect the extraction of rubocop-ast
• Update `VersionChanged` from 1.0 to 0.84
• Fix typoes
• Remove unneeded conditionals with latest rubocop-ast
• [Fix rubocop-hq/rubocop-ast#7] Reimport error from rubocop-ast
• [Fix rubocop-hq/rubocop-ast#7] Create aliases for AST::NodePattern, ProcessedSource and Token
• [Fix rubocop-hq/rubocop-ast#7] Import ProcessedSource#comment_config and related method from rubocop-ast
• [Fix #7972] Fix an incorrect autocorrect for `Style/HashSyntax` (#7973)
• Add new `Lint/DeprecatedOpenSSLConstant` cop
• Support any expression as the start index in Style/SlicingWithRange (#7967)
• Improve FrozenStringLiteralComment autocorrection.
• Merge pull request #7964 from marcandre/fix_disable
• Fix calculation in disable_offense.
• [Fix #7962] Fix a false positive for `Lint/ParenthesesAsGroupedExpression`
• Have `rubocop -V` output rubocop-ast's version
• Bump required rubocop-ast
• Update links to rubocop-ast [doc] [ci skip]
• Amend Changelog for [#7735] [doc] [ci skip]
• Change enforced style to `conditionals` for `Style/AndOr`
• Require rubocop-ast gem
• Simplify spec further
• Tweak spec to define method only once
• Simplify specs
• [Fix #7953] Fix an error for `Lint/AmbiguousOperator`
• Change the max line length of `Layout/LineLength` to 120

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[depfu]

Closed in favor of #139.