[ruby] Upgrade rubocop to version 1.24.0 #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![depfu[bot]](https://avatars.githubusercontent.com/in/715?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.
What changed?
✳️ rubocop (~> 1.23.0 → ~> 1.24.0) · Repo · Changelog
Release Notes
1.24.0
Does any of this look wrong? Please let us know.
Commits
See the full diff on Github. The new version differs by 59 commits:
Cut 1.24Update ChangelogAdd new `InternalAffairs/RedundantMethodDispatchNode` copAdd new `Naming/BlockForwarding` cop[Fix #10303] Add `AllowedNumbers` option to `Style/NumericLiterals`Merge pull request #10309 from fatkodima/duplicated_gem-multiple-statementsFix a false positive for `Bundler/DuplicatedGem` when a gem conditionally duplicated within multi-statement bodiesSupport Ruby 3.1's hash value omission for `Style/HashSyntax`Make `Style/CollectionCompact` aware of block passSupport Ruby 3.1's hash value omission for `Layout/HashAlignment`Merge pull request #10307 from koic/support_numbered_parameter_for_metrics_length_copsSupport Ruby 2.7's numbered parameter for `Metrics/*Length` copsAdd new `Style/FileWrite` copMerge pull request #10306 from koic/fix_incorrect_autocorrect_for_style_hash_conversion[Fix #10305] Fix an incorrect autocorrect for `Style/HashConversion`Merge pull request #10212 from HeroProtagonist/documentation-url-from-cli-7671[Fix #7671] Add cli option to print documentation url for copsMerge pull request #10301 from koic/fix_incorrect_autocorrect_for_dot_position_and_redudant_self[Fix #10300] Fix an incorrect autocorrect for `Layout/DotPosition` and `Style/RedundantSelf`Merge pull request #10298 from koic/fix_false_positive_for_lint_deprecated_open_ssl_constant[Fix #10297] Fix a false positive for `Lint/DeprecatedOpenSSLConstant`Merge pull request #10291 from koic/support_hash_value_omission_for_layout_space_after_colonSupport Ruby 3.1's hash value omission syntax for `Layout/SpaceAfterColon`Use Ruby 3.1 parser for docs[Fix #10282] Fix an incorrect autocorrect for `Style/EmptyCaseCondition`[Fix #10284] Fix an incorrect autocorrect for `Style/RedundantRegexpCharacterClass`[Fix #10285] Fix an incorrect autocorrect for `Style/SoleNestedConditional`Merge pull request #10279 from koic/new_support_ruby31_anonymous_block_argument_syntaxAdd new `Style/FileRead` copRemove an obsolete development taskSupport Ruby 3.1's anonymous block argument syntaxMerge pull request #10277 from koic/fix_incorrect_autocorrect_for_style_redundant_interpolation[Fix #10276] Fix an incorrect autocorrect for `Style/RedundantInterpolation`Tweak Style/CharacterLiteral cop descriptionExplain why `?\C-\M-d` is good[Fix #8586] Add AllowForAlignment config param in CommentIndentationTweak suggested RuboCop extension URLMerge pull request #10274 from koic/fix_false_positive_for_internal_affairs_undefined_config[Fix #10273] Fix a false positive for `InternalAffairs/UndefinedConfig`Merge pull request #10270 from koic/mark_unsafe_autocorrect_for_lint_incompatible_io_select_with_fiber_scheduler[Fix #10269] Mark unsafe autocorrect for `Lint/IncompatibleIoSelectWithFiberScheduler`Fix a typo[Docs] Add a few extra milestones to the history[Fix #10265] `Style/IfInsideElse` to be able to handle `if-then` nested inside an `else` without clobbering.Extract `IfThenCorrector` from `Style/OneLineConditional` to replace an `if-then` structure with a multiline if.[Docs] Improve section for development (#10267)Merge pull request #10264 from koic/fix_an_incorrect_autocorrect_for_style_method_call_with_args_parenthesesFix an incorrect auto-correct for `Style/MethodCallWithArgsParentheses`Merge pull request #10259 from rubocop/dead_codeRemove unused codeAdd new `Style/MapToHash` cop.Fix --autocorrect error in changelogMake `Lint/DeprecatedClassMethods` aware of `ENV.freeze`Display deprecation message for `EnforceSuperclass` moduleMerge pull request #10250 from dvandersluis/security/openUpdate docs and tests for `Security/Open`.Merge pull request #10247 from dvandersluis/fix/require-mfa-docsFix docs for `Gemspec/RequireMFA`.Switch back the docs versionDepfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with
@depfu rebase.All Depfu comment commands