Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ruby] Upgrade rubocop to version 1.50.0 #245

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

depfu[bot]
Copy link
Contributor

@depfu depfu bot commented Apr 12, 2023

Here is everything you need to know about this upgrade. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop (~> 1.49.0 → ~> 1.50.0) · Repo · Changelog

Release Notes

1.50.0

New features

  • #11749: Add new Lint/DuplicateMatchPattern cop. (@koic)
  • #11773: Make Layout/ClassStructure aware of singleton class. (@koic)
  • #11779: Make Lint/RedundantStringCoercion aware of print method arguments. (@koic)
  • #11776: Make Metrics/ClassLength aware of singleton class. (@koic)
  • #11775: Make Style/TrailingBodyOnClass aware of singleton class. (@koic)

Bug fixes

  • #11758: Fix a false positive for Style/RedundantLineContinuation when line continuations for string. (@koic)
  • #11754: Fix a false positive for Style/RedundantLineContinuation when using && and || with a multiline condition. (@ydah)
  • #11765: Fix an error for Style/MultilineMethodSignature when line break after def keyword. (@koic)
  • #11762: Fix an incorrect autocorrect for Style/ClassEqualityComparison when comparing a variable or return value for equality. (@koic)
  • #11752: Fix a false positive for Style/RedundantLineContinuation when using line concatenation and calling a method without parentheses. (@koic)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 27 commits:


Depfu Status

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands
@​depfu rebase
Rebases against your default branch and redoes this update
@​depfu recreate
Recreates this PR, overwriting any edits that you've made to it
@​depfu merge
Merges this PR once your tests are passing and conflicts are resolved
@​depfu close
Closes this PR and deletes the branch
@​depfu reopen
Restores the branch and reopens this PR (if it's closed)
@​depfu pause
Ignores all future updates for this dependency and closes this PR
@​depfu pause [minor|major]
Ignores all future minor/major updates for this dependency and closes this PR
@​depfu resume
Future versions of this dependency will create PRs again (leaves this PR as is)

@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (3fbc965) 100.00% compared to head (7a22fdb) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #245   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        55           
  Lines         3186      3186           
=========================================
  Hits          3186      3186           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AlexWayfer AlexWayfer merged commit a1a13d5 into main Apr 12, 2023
@AlexWayfer AlexWayfer deleted the depfu/update/rubocop-1.50.0 branch April 12, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant