This repository has been archived by the owner on Dec 21, 2021. It is now read-only.
feat: forward rawBody & hmacSignature on emit #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea here is to allow user-controlled code to perform the validation. The rawBody and HMAC signature can be verified by the homebridge-nello plugin. This backend does not need to know the pre-shared key and therefore, by design, cannot tamper with the data.
AlexanderBabel
approved these changes
Aug 4, 2020
|
@AlexanderBabel Thanks! Looks like there's a rights issue with the deployment: https://github.com/AlexanderBabel/nello-backend/runs/944953937?check_suite_focus=true |
|
No problem. That's fortunately not an issue, because that was the old deployment way. The new way uses the image from GitHub Packages. It should be deployed in a few minutes. |
|
Also I added an info page, so that everyone can see if the backend uses the lastest version. When the deployment has been finished you can find it under: https://nello.alexdev.de |
|
Nice, thanks! I'll test out lukasroegner/homebridge-nello#56 later today |
|
Regarding your package.json version issue, you need this: https://github.com/semantic-release/npm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea here is to allow user-controlled code to perform the validation. The rawBody and HMAC signature can be verified by the homebridge-nello plugin. This backend does not need to know the pre-shared key and therefore, by design, cannot tamper with the data.
The parsed body is retained to maintain backwards-compatibility, but could be eventually removed.
Proposed handling: lukasroegner/homebridge-nello#56