Serialization fixes and an extra DiscreteAction #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 11, 2014 02:42
Fixed manualDeadZones and treatHatsAsButtons not being serialized properly
Moved toolbar btn image into addon folder
Saving changes right away should prevent loss of changes in case of crashes etc.
|
This is really cool :) Thank you so much for the contribution, I really appreciate the help! |
AlexanderDzhoganov
added a commit
that referenced
this pull request
Nov 11, 2014
Serialization fixes and an extra DiscreteAction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem with flybywire not saving my manual deadzone settings, which I have now fixed. I added a DiscreteAction for doing pitch trimming, which works really well compared to analog trimming. I also moved the toolbar button image into the addon folder, since this is what other addons seem to do. I lost a lot of settings because I didn't know I had to manually save configuration under Mod Settings first, so I made it save state whenever a setting window is closed, which might help a lot of new users.
This is my first ever pull request on a KSP addon, so do inspect my code and make sure I didn't make any mistakes. Thanks for a really awesome addon!