KSP 1.4 Linux compatibility #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think Unity on Windows does not use SDL, but I don't have a Windows box to confirm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent Unity versions use SDL for input handling on Linux. That means, in order not to break KSP's input system, we mustn't consume any input inside the mod. As far as I understand the code I changed, its main purpose is to repopulate the event queue of SDL (as the event that gets polled is not used anywhere). The same effect can be achieved by pumping the event queue without reading from it.
That's what this pull request does.
This plugin is now interesting again, as KSP 1.4.1 has broken Joystick/Gamepad handling on Linux. It's currently impossible to assign input axis, but Advanced Fly-By-Wire just works.
Also, Toolbar Continued has been updated to 1.4.1, so Advanced Fly-By-Wire is just this patch and a recompile away from working on the new KSP.