-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GMMRegression scikit-learn RegressorMixin #29
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some comments to the code. In addition, I suggest to add an extra requirements section "all" in setup.py
and document the extension in the readme.
edit: Just noticed that scikit-learn is already part of the extra requirement section all
.
Most of my comments have been addressed properly. Three inline comments are still open. In addition, the behavior of the class should be documented here. The code snippet from the top would be perfect. |
Just checked the test coverage with if X.ndim == 1:
X = np.expand_dims(X, 1)
if y.ndim == 1:
y = np.expand_dims(y, 1) etc. |
Sorry for taking this long.. |
No problem.
OK, I will have it on my list.
There is fetch_california_housing. This dataset should be similar, right? |
I merged this pull request to master. Thanks for your contribution @mralbu I also added an example with sklearn's learning curve: https://github.com/AlexanderFabisch/gmr/blob/master/examples/plot_sklearn_learning_curve.py |
Adds a scikit-learn RegressorMixin.
Addressing #27.
Sample usage proposed: