Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump serde_yaml to 0.9 #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fennewald
Copy link

  • Bumps serde_yaml to 0.9, the most recent release
  • Bumps format_serde_error to 0.3.1 from 0.3.0
  • Updated a few tests with the new expected output

@fennewald
Copy link
Author

Just noticed PR 22, in it's current form this PR ignores 0.8 compatibility. Given the slightly different outputs, the only solution I can imagine would involve gating serde_yaml versions behind a feature flag (e.g. serde_yaml_0.8, and serde_yaml_0.9 feature flags. This feels verbose.

@dsully
Copy link

dsully commented May 7, 2024

I believe I'm encountering this error due to the older version of serde_yaml as well:

CleanShot 2024-05-07 at 11 42 11@2x

Also with the recent serde_yaml deprecation, there are a few replacements that should be allowed IMO.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants