Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portion upload to conda-forge? #31

Closed
egemenimre opened this issue Jun 29, 2020 · 15 comments
Closed

portion upload to conda-forge? #31

egemenimre opened this issue Jun 29, 2020 · 15 comments

Comments

@egemenimre
Copy link
Contributor

Hullo,

I have been trying to upload my package to conda-forge and it turned out that I can't, as portion is not there and conda-forge really does not want external (read: pypi-only) dependencies.

My question is, would you consider uploading portion to conda-forge so that I can refer to your package there as a dependency?

@AlexandreDecan
Copy link
Owner

Hello,

I'm not used to conda-forge, but I can give it a try if it's easy to integrate this in our "publish CI". Do you have some pointers where I can find how to proceed?

@egemenimre
Copy link
Contributor Author

Thanks for your reply and considering adding your project to conda. The process (as I understand it) is easy if you already have a PyPI package.

You can find the tutorial here: https://conda-forge.org/docs/maintainer/adding_pkgs.html

Essentially, running conda skeleton pypi portion on terminal will generate a meta.yaml file. You then fork the conda-staging github project, copy the contents of your meta.yaml there and then do a pull request, which triggers a bot. This bot lints the yaml file and then checks your project (as yours do not have dependencies and 100% tested, I see no probs). If all goes well, I think the project is automatically updated.

I managed to come from zero knowledge of conda to this step in about two hours, at which point I got a dependency fail due to portion. I'm sure it would take you much less.

Further down the same page is the instructions to maintain the package and CI integration.

@AlexandreDecan
Copy link
Owner

Thanks, I'll have a look! By the way, it seems a package can be added and maintained on conda-forge, not only by an "official" maintainer of a project. Would you agree to maintain portion on conda-forge?

@egemenimre
Copy link
Contributor Author

Not only do I agree, I also took the liberty to actually start the process with conda-forge. I prepared the meta.yaml, all tests passed with flying colours.

It looks like all we need is a confirmation from you and we are good to go:
conda-forge/staged-recipes#12054 (comment)

@AlexandreDecan
Copy link
Owner

Thank you!

@AlexandreDecan
Copy link
Owner

I guess we can close this issue now?

Feel free to contact me if you need me or if there is anything I need to do on conda-forge when releasing a new version of portion! I'm not used to conda-forge, so I count on you to keep me informed ;)

@egemenimre
Copy link
Contributor Author

Sure, you can close this. And now your package 2.0.2 is really on conda-forge - just checked it. :)

@AlexandreDecan
Copy link
Owner

👍

@AlexandreDecan
Copy link
Owner

Hello @egemenimre
I do not see the latest release (2.1.2) on conda-forge. I created the release this afternoon the usual way (a tag and a deployment on PyPI). Is there anything specific I should do for conda-forge?

@AlexandreDecan
Copy link
Owner

Sorry, you can forget about my comment ;-) I've just seen I need to merge the corresponding PR. I haven't received the notification for it, that's why I was a bit confused ;-)

@egemenimre
Copy link
Contributor Author

egemenimre commented Sep 16, 2020 via email

@AlexandreDecan
Copy link
Owner

Hello @egemenimre

I hope you're doing well;) I've a question for you about conda-forge: I recently switched to poetry to build portion and "manage" its dependencies (at least from a "manifest file" point of view). I've not (yet) released this change and before doing so, I would like to know whether this can/could/will affect our deployment on conda-forge.

@egemenimre
Copy link
Contributor Author

egemenimre commented May 28, 2021 via email

@AlexandreDecan
Copy link
Owner

Thanks for your answer. Given the workflow, it's indeed unlikely that it could be affected by how the package is built. That's good news ;-)

@egemenimre
Copy link
Contributor Author

egemenimre commented May 29, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants