Add demodulation mode to recorder filename template

[rs1729]

#893 (comment)

Recorder filename

If $r is used in name template, it adds the demodulation type of "Radio" to the filename.
For "Baseband" it would be "IQ",
for "Audio" one of
"NFM", "WFM", "AM", "DSB", "USB", "CW", "LSB", "RAW".

(If radio "RAW" is selected, recording "Stereo" is recommended.)

[AlexandreRouma]

Many things wrong here:

1. Why get the selected VFO when the name is based on the recorded VFO and its name is already given (see line 448 for example).
2. Why a huge if/else statement when std::map<int, const char*> exists?

I'll implement this myself

[AlexandreRouma]

Seems that the huge switch statement is because it was copied from the rigctl_server code, my bad. I'll fix that too, it's unacceptable/

[rs1729]

Sorry, I don't know the code very well. Yes, I believe I took rigctl_server as an example, and the if/else style. There is another module, discord_integration

SDRPlusPlus/misc_modules/discord_integration/src/main.cpp

Lines 84 to 109 in 9c1361a

	if (core::modComManager.interfaceExists(selectedName)) {
	if (core::modComManager.getModuleName(selectedName) == "radio") {
	int modeNum;
	core::modComManager.callInterface(selectedName, RADIO_IFACE_CMD_GET_MODE, NULL, &modeNum);
	if (modeNum == RADIO_IFACE_MODE_NFM) { strcpy(mode, "NFM"); }
	else if (modeNum == RADIO_IFACE_MODE_WFM) {
	strcpy(mode, "FM");
	}
	else if (modeNum == RADIO_IFACE_MODE_AM) {
	strcpy(mode, "AM");
	}
	else if (modeNum == RADIO_IFACE_MODE_DSB) {
	strcpy(mode, "DSB");
	}
	else if (modeNum == RADIO_IFACE_MODE_USB) {
	strcpy(mode, "USB");
	}
	else if (modeNum == RADIO_IFACE_MODE_CW) {
	strcpy(mode, "CW");
	}
	else if (modeNum == RADIO_IFACE_MODE_LSB) {
	strcpy(mode, "LSB");
	}
	}
	}

that is very similar.

My idea was: If recording baseband, append "IQ", else if recording the selected VFO audio, append the selected mode.
"RAW" audio would be like "IQ", but only the 48k IF. Also I was wondering if "stereo" should be default for RAW?

Thanks.

[rs1729]

Just tested, now if I record baseband, I get e.g.:
baseband_20230906_114527_403500066Hz_Unknown.wav

Would rather set

SDRPlusPlus/misc_modules/recorder/src/main.cpp

Line 470 in 9c1361a

const char* modeStr = "Unknown";

to modeStr = "IQ",
such that
baseband_20230906_114527_403500066Hz_IQ.wav.
"baseband"..."IQ" is a bit redundant, but the default if radio/audio is not selected.

Another question:
What if the returned mode in

            core::modComManager.callInterface(name, RADIO_IFACE_CMD_GET_MODE, NULL, &mode);
            modeStr = radioModeToString[mode];

is not found in radioModeToString[mode]?