Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed spectran_http_source #1352

Closed
wants to merge 4 commits into from
Closed

Conversation

hb9fxq
Copy link
Contributor

@hb9fxq hb9fxq commented Mar 7, 2024

Fixed spectran_http_source block to work poperly with the IQ Demodulator Block, as intended by the Aaronia RTSA Suite HTTP API design.

Also introduced fixed / realistic sample rates to be used withing a network environment.

Frank Zosso added 3 commits March 7, 2024 12:42
…s as intended by Aaronia RTSA API architecture
…s as intended by Aaronia RTSA API architecture
…s as intended by Aaronia RTSA API architecture
@hb9fxq
Copy link
Contributor Author

hb9fxq commented Mar 7, 2024

we'll put a documentation how to configure the mission with examples into the Aaronia Support forum.

image

…s as intended by Aaronia RTSA API architecture
@AlexandreRouma
Copy link
Owner

AlexandreRouma commented Mar 7, 2024

The code style doesn't match the rest of modern SDR++, some lines are commented out instead of removed (one of which shouldn't be commented in the first place), the ImGui widget IDs use the wrong prefix of spectran instead of spectran_http which will cause conflicts, the 4 commits are all named the same, the layout of the widgets is not done properly and their order is inconsistent with all other networked SDR++ sources.

image

Please, there's a reason the issue template and contributing.md says I don't accept pull request. Just opening an issue saying you wanted certain changes done to how it works would have been faster and easier for both of us. I appreciated that you want to directly contribute instead of having me do the work but in my situation it's just much more convenient for me to do it right the first time around.

So please open an issue with what needs to change from the user's point of view and I'll implement something.

@hb9fxq
Copy link
Contributor Author

hb9fxq commented Mar 8, 2024

#1354

@hb9fxq hb9fxq closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants