Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child process does not stops #358

Closed
nikto-b opened this issue May 30, 2019 · 3 comments · Fixed by #1032
Closed

Child process does not stops #358

nikto-b opened this issue May 30, 2019 · 3 comments · Fixed by #1032
Labels
enhancement New feature or request

Comments

@nikto-b
Copy link
Contributor

nikto-b commented May 30, 2019

After killing waybar (for refreshing config, etc), child processes keeps working
I spent 10 minutes on killing custom script with loop for checking capslock state
Fix that plz :)
ArchLinux, waybar-git from AUR
Waybar v0.6.6-28-gfcf2d18 (May 30 2019, branch 'master')

@toke
Copy link
Contributor

toke commented Jun 7, 2019

I had looked into that and I have a "rough" version. But as I'm not fluent in C++ it's a bit harsh and still dies with a segfault some seconds later (which is not as bad a it has to be exited anyway ;))

BUT: As a quickfix for (at least bash-scripts) it should be possible to add set -euo pipefail in them and if one of the outputs fail it should exit.
Or use killall -g waybar which kills the process group.

@b-zee
Copy link

b-zee commented Jul 17, 2020

I have encountered the same problem and can confirm processes do not exit. I was testing styles and 'reloaded' sway multiple times.

Excerpt from ps --forest aux:

user      17502  0.0  0.0   7172  2804 tty1     S    13:12   0:00 sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      17509  0.0  0.1 177584 19112 tty1     Sl   13:12   0:00  \_ python /home/user/.config/waybar/mediaplayer.py
user      17567  0.0  0.0   7172  2856 tty1     S    13:12   0:00 sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      17574  0.0  0.1 177584 19208 tty1     Sl   13:12   0:00  \_ python /home/user/.config/waybar/mediaplayer.py
user      17657  0.0  0.0   7172  2952 tty1     S    13:14   0:00 sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      17663  0.0  0.1 177584 19188 tty1     Sl   13:14   0:00  \_ python /home/user/.config/waybar/mediaplayer.py
user      17737  0.0  0.0   7172  2724 tty1     S    13:15   0:00 sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      17743  0.0  0.1 177584 19116 tty1     Sl   13:15   0:00  \_ python /home/user/.config/waybar/mediaplayer.py
user      17928  0.0  0.0   7172  2772 tty1     S    13:16   0:00 sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      17932  0.0  0.1 177584 19188 tty1     Sl   13:16   0:00  \_ python /home/user/.config/waybar/mediaplayer.py
user      17989  0.0  0.0   7172  2744 tty1     S    13:17   0:00 sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      17996  0.0  0.1 177584 19124 tty1     Sl   13:17   0:00  \_ python /home/user/.config/waybar/mediaplayer.py
user      18056  0.0  0.0   7172  2816 tty1     S    13:17   0:00 sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      18063  0.0  0.1 177584 19100 tty1     Sl   13:17   0:00  \_ python /home/user/.config/waybar/mediaplayer.py
user      18592  0.0  0.3 980108 54124 tty1     Sl+  13:20   0:00 waybar -b bar-0
user      18608  0.0  0.0   7172  2956 tty1     S    13:20   0:00  \_ sh -c python $HOME/.config/waybar/mediaplayer.py 2> /dev/null
user      18614  0.0  0.1 177584 19140 tty1     Sl   13:20   0:00      \_ python /home/user/.config/waybar/mediaplayer.py

@fourstepper
Copy link

This issue is also present for me - perhaps this could be somehow handled from the mediaplayer.py script itself?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants