Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some child processes are still left open when waybar terminates #1713

Closed
matejdro opened this issue Oct 12, 2022 · 5 comments · Fixed by #1748 or #2629
Closed

Some child processes are still left open when waybar terminates #1713

matejdro opened this issue Oct 12, 2022 · 5 comments · Fixed by #1748 or #2629
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@matejdro
Copy link

matejdro commented Oct 12, 2022

To reproduce:

  1. Setup a custom module (and add that module to the waybar):
    "custom/process-broken-demo": {
        "return-type": "json",
        "escape": false,
        "exec": "$HOME/.config/waybar/process-test.sh"
    }
  1. Put this into the process-test.sh:
#!/usr/bin/env bash

function_call() {
    sleep 1
}

while read line; do
        function_call
done < <(sleep 9999)
  1. Run ps -u | grep process-test. Note that the only returned entry should be the grep process.
  2. Start waybar.
  3. Run step 3 again. Note that there are two extra processes now, started by waybar
  4. Close waybar
  5. Run step 3 again. Note that one extra process is still there, even though waybar has been closed

Probably related to #358?

@Alexays
Copy link
Owner

Alexays commented Nov 2, 2022

Can you check with #1748?

@matejdro
Copy link
Author

matejdro commented Nov 6, 2022

Thanks for looking into it. I tried it out and it still seems to happen. I've updated the first post with full reproduce steps, so it should be much easier to reproduce now.

@lilydjwg
Copy link
Contributor

lilydjwg commented Nov 6, 2022

I noticed that this issue states a different case than what I had and have fixed. I have zombies when a monitor disconnects and reconnects repeatedly, but this issue is about waybar termination.

@matejdro
Copy link
Author

@Alexays Can you reopen this issue? From my previous testing, PR does not fix this issue.

@Alexays Alexays reopened this Nov 24, 2022
@savely-krasovsky
Copy link

Also there is a problem with mediaplayer.py which is python and does not use process substitution.
изображение

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
4 participants