Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add length limits for MPD module tags #1002

Merged
merged 8 commits into from
Mar 15, 2021
Merged

Conversation

nullobsi
Copy link
Contributor

adds the following configuration options to the MPD module:

  • artist-len
  • album-len
  • album-artist-len
  • title-len

to control the maximum length of the tags when they are displayed on the bar.

Copy link

@YerinAlexey YerinAlexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Owner

@Alexays Alexays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, but what do you think of my proposal?

src/modules/mpd/mpd.cpp Outdated Show resolved Hide resolved
@nullobsi
Copy link
Contributor Author

alright, i've fixed it up 😄

@Alexays
Copy link
Owner

Alexays commented Mar 15, 2021

LGTM, thx

@Alexays
Copy link
Owner

Alexays commented Mar 15, 2021

Could you also update the github wiki?

@Alexays Alexays merged commit b1dd620 into Alexays:master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants