Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wlr/taskbar] Fix unhandled exception crash when icon name is a path. #1018

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

jgmdev
Copy link
Contributor

@jgmdev jgmdev commented Feb 4, 2021

Fixes a crash and handles the edge case where the application.desktop 'Icon' property points to the absolute path of the icon file instead of an icon name, for example:

[Desktop Entry]
Name=Cendric
Comment=RPG and Platformer
Exec=/usr/bin/Cendric
Terminal=false
Icon=/usr/share/Cendric/res/icon.ico
Type=Application
Categories=Game;

src/modules/wlr/taskbar.cpp Outdated Show resolved Hide resolved
@Alexays Alexays merged commit 71f9ed3 into Alexays:master Feb 4, 2021
@Alexays
Copy link
Owner

Alexays commented Feb 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants