Use user-defined mode when toggling visibility rather than resetting to default #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorgnarg
changed the title
Alexays
reviewed
Mar 13, 2022
| @@ -665,7 +665,11 @@ void waybar::Bar::onMap(GdkEventAny*) { | |||
|
|
|||
| void waybar::Bar::setVisible(bool value) { | |||
| visible = value; | |||
| setMode(visible ? MODE_DEFAULT : MODE_INVISIBLE); | |||
| if (auto mode = config.get("mode", {}); mode.isString()) { | |||
| setMode(visible ? config["mode"].asString() : MODE_INVISIBLE); | |||
There was a problem hiding this comment.
Do you think it's worse to check if mode is available?
Against a hard-coded list, for example.
There was a problem hiding this comment.
setMode already does the check with fallback to default, no need to do it twice.
alebastr
approved these changes
Mar 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #958 and #491 (or at least this comment), this way if the bar is configured to be in overlay mode, it will stay in that mode when it's re-shown after being hidden. If there's a better way to do this, let me know, I just reused the code elsewhere that retrieved the config mode in the first place