Hide/Unhide temperature module when "format*" is empty. #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexays
reviewed
Mar 17, 2022
src/modules/temperature.cpp
Outdated
Comment on lines
6
to
10
| if (config_["format"].asString().empty() && config_["format-critical"].asString().empty()) { | ||
| throw std::runtime_error("Format configuration is not defined"); | ||
| } else if (config_["format"].asString().empty()) { | ||
| format_.clear(); | ||
| } |
Alexays
reviewed
Mar 17, 2022
src/modules/temperature.cpp
Outdated
Comment on lines
6
to
10
| if (config_["format"].asString().empty() && config_["format-critical"].asString().empty()) { | ||
| throw std::runtime_error("Format configuration is not defined"); | ||
| } else if (config_["format"].asString().empty()) { | ||
| format_.clear(); | ||
| } |
Alexays
reviewed
Mar 17, 2022
src/modules/temperature.cpp
Outdated
Comment on lines
43
to
49
| if(format.empty()) | ||
| { | ||
| event_box_.hide(); | ||
| return; | ||
| } else { | ||
| event_box_.show(); | ||
| } |
Alexays
reviewed
Mar 17, 2022
src/modules/temperature.cpp
Outdated
Comment on lines
43
to
49
| if(format.empty()) | ||
| { | ||
| event_box_.hide(); | ||
| return; | ||
| } else { | ||
| event_box_.show(); | ||
| } |
There was a problem hiding this comment.
Thanks. Please check the new one commit :)
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually even is set
"format" : ""waybar displays some spaces. But when user wants to have the only notification when temperature threshold is triggered it looks not so good.Current fix does:
"format" : ""neither"format-critical" : ""is defined - throw an exception in order to have temperature module disabled during the start processconfig example: