Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a device with a battery driver that is not currently supported by your battery module. A PineNote with a Rockchip RK817 battery controller. The driver is not upstreamed yet, but I think the changes are generic enough for this not to matter.
It does not have a capacity, so it fails the initial check, and it does not have
current_now
orvoltage_now
.I added
charge_now
to the initial file check, sincecapacity
is only needed ifcharge_now
doesn't exist.I also added a check whether
current_now
orvoltage_now
exist, and if not attempt to readcurrent_avg
andvoltage_avg
Please let me know what you think.