Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partially revert 3af1853260 to fix use-after-free #2265

Merged
merged 1 commit into from
Jul 4, 2023

Commits on Jul 1, 2023

  1. Partially revert 3af1853 to fix use-after-free

    After upgrading to the latest release of Waybar the bar will crash
    whenever I close the laptop lid. After some debugging I believe it is
    because the watching added by watch_name is not being correctly canceled
    using unwatch_name. After the Tray object and Host object are destroyed,
    additional callbacks will become use-after-free.
    
    Looks like commit 3af1853 removed the
    unwatch_name. I'm not sure why it did that, but it seemed dangerous.
    
    Additionally, bus_name_id_ is created by own_name. According to that
    function's documentation, the correct inverse operation is unown_name.
    tengyifei committed Jul 1, 2023
    Configuration menu
    Copy the full SHA
    cd49eef View commit details
    Browse the repository at this point in the history