Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some build warnings #2266

Merged
merged 1 commit into from
Jul 1, 2023
Merged

Fixed some build warnings #2266

merged 1 commit into from
Jul 1, 2023

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented Jul 1, 2023

While compiling Waybar, I had these warnings:

In file included from ../src/modules/network.cpp:1:
../include/modules/network.hpp: In constructor ‘waybar::modules::Network::Network(const std::string&, const Json::Value&)’:
../include/modules/network.hpp:87:16: warning: ‘waybar::modules::Network::rfkill_’ will be initialized after [-Wreorder]
   87 |   util::Rfkill rfkill_;
      |                ^~~~~~~
../include/modules/network.hpp:81:9: warning:   ‘float waybar::modules::Network::frequency_’ [-Wreorder]
   81 |   float frequency_;
      |         ^~~~~~~~~~
../src/modules/network.cpp:80:1: warning:   when initialized here [-Wreorder]
   80 | waybar::modules::Network::Network(const std::string &id, const Json::Value &config)
      | ^~~~~~
[141/150] Compiling C++ object waybar.p/src_util_rfkill.cpp.o
../src/util/rfkill.cpp: In member function ‘bool waybar::util::Rfkill::on_event(Glib::IOCondition)’:
../src/util/rfkill.cpp:66:13: warning: comparison of integer expressions of different signedness: ‘ssize_t’ {aka ‘long int’} and ‘long unsigned int’ [-Wsign-compare]
   66 |     if (len < RFKILL_EVENT_SIZE_V1) {
      |             ^

This PR fixes these warnings.

@Alexays Alexays merged commit b62e5eb into Alexays:master Jul 1, 2023
@Alexays
Copy link
Owner

Alexays commented Jul 1, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants