Stop MPRIS module from updating every ~20ms #2276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PlayerPlay() callbacks get triggered without regard for update interval.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that while MPRIS module is running and music is playing, all tooltips on other modules stop working. When music is paused or stopped, they work again.
Upon investigation, MPRIS onPlayerMetadata(), onPlayerPlay() callbacks get triggered every ~20ms and call Mpris::update() without regard for update interval configured. The Mpris label gets updated every time and interferes with showing tooltips for other modules.
The fix is to ignore any Mpris::update() calls until the configured update interval elapses from the previous non-ignored call.