Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix simpleclock module compilation with recent fmt #2412

Merged
merged 1 commit into from Aug 16, 2023
Merged

Fix simpleclock module compilation with recent fmt #2412

merged 1 commit into from Aug 16, 2023

Conversation

jpalus
Copy link
Contributor

@jpalus jpalus commented Aug 16, 2023

both format_ and tooltip_format are dynamically provided formats so wrap them in fmt::runtime()

@jpalus
Fix simpleclock module compilation with recent fmt
abd7a0c 
both `format_` and `tooltip_format` are dynamically provided formats so
wrap them in `fmt::runtime()`
@Alexays Alexays merged commit aecd807 into Alexays:master Aug 16, 2023
8 checks passed
@jpalus
Copy link
Contributor Author

jpalus commented Aug 16, 2023

It attempts to fix another issue raised in #2403 but note that while I verified the change fixes build, I didn't verify if it actually works. I would be surprised if it didn't though.

@jpalus jpalus mentioned this pull request Aug 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jpalus @Alexays