Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JSON parsing with hexadecimal characters #2496

Merged
merged 1 commit into from
Jan 28, 2024

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented Sep 10, 2023

Fixes #2495 and #2475

The JSON spec doesn't allow characters like \xab. Instead, it should be converted to unicode: \u00ab.

It's my first time writing catch2 tests, let me know if I did something wrong.

* replace \x with \u00 to follow JSON spec
* fixes Alexays#2475 and Alexays#2495
* added unit tests for json parsing
@zjeffer zjeffer changed the title Added tests for json parsing Fix JSON parsing with hexadecimal characters Jan 14, 2024
@zjeffer
Copy link
Contributor Author

zjeffer commented Jan 14, 2024

@Nyayurn can you test if you still have your bug with this new parser?

@Nyayurn
Copy link

Nyayurn commented Jan 15, 2024

@Nyayurn can you test if you still have your bug with this new parser?

It's fine

@Nyayurn
Copy link

Nyayurn commented Jan 15, 2024

image

But it's a new bug with clock, in screenshot's right top the clock compoment do not work

@zjeffer
Copy link
Contributor Author

zjeffer commented Jan 15, 2024

Can you show the console output, I'd like to see if there are any errors from the clock component.

@Nyayurn
Copy link

Nyayurn commented Jan 16, 2024

image
and the config
image

@zjeffer
Copy link
Contributor Author

zjeffer commented Jan 20, 2024

@Nyayurn with your config, I get the same error on latest master.
Something seems to be wrong with your format string..

I think the clock icon needs to be outside of the {} brackets, like this: "<icon>{:%I:%M %p %d/%m/%Y}"

It works for me on both latest master and this PR:

image

@Nyayurn
Copy link

Nyayurn commented Jan 23, 2024

@Nyayurn with your config, I get the same error on latest master. Something seems to be wrong with your format string..

I think the clock icon needs to be outside of the {} brackets, like this: "<icon>{:%I:%M %p %d/%m/%Y}"

It works for me on both latest master and this PR:

image

Thanks, It's work now

@zjeffer
Copy link
Contributor Author

zjeffer commented Jan 24, 2024

@Alexays This is ready to be reviewed.

@Alexays
Copy link
Owner

Alexays commented Jan 28, 2024

LGTM, thx for this fix!

@Alexays Alexays merged commit 5534fc4 into Alexays:master Jan 28, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The jsonparser doesn't work with escaped unicode characters
3 participants