Applied clang-tidy suggestions for hyprland workspaces

[zjeffer]

First test after merging #2595

Let me know if anything needs to change.

[Alexays]

LGTM

[zjeffer]

@Alexays FYI, I'm implementing the GitHub action for clang-tidy checks in this PR: zjeffer#1

I'm having some trouble here during the clang-tidy step (https://github.com/zjeffer/Waybar/actions/runs/7126784812/job/19405372955):

Performing checkup on src/modules/hyprland/workspaces.cpp
  INFO:CPP Linter:Running "clang-tidy-17 --export-fixes=.cpp-linter_cache/clang_tidy_output.yml -p /home/runner/work/Waybar/Waybar/build --extra-arg= src/modules/hyprland/workspaces.cpp"
  DEBUG:CPP Linter:Output from clang-tidy:
  /home/runner/work/Waybar/Waybar/src/modules/hyprland/workspaces.cpp:1:10: error: 'modules/hyprland/workspaces.hpp' file not found [clang-diagnostic-error]
      1 | #include "modules/hyprland/workspaces.hpp"
        |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

The problem is the project is not configured during this step, so we don't generate a compile_commands.json file. That's why it can't find the hpp file.

I tried using your waybar:debian image and configuring the project like this: https://github.com/zjeffer/Waybar/actions/runs/7120457195/workflow, but that caused issues with installing clang-tidy (https://github.com/zjeffer/Waybar/actions/runs/7120457195/job/19387733236):

Run if [[ "Linux"  == "Linux" ]]; then
  if [[ "Linux"  == "Linux" ]]; then
    sudo apt-get update
    # First try installing from default Ubuntu repositories before trying LLVM script
    if ! sudo apt-get install -y clang-format-17 clang-tidy-17; then
      # This LLVM script will add the relevant LLVM PPA: https://apt.llvm.org/
      wget https://apt.llvm.org/llvm.sh -O $GITHUB_ACTION_PATH/llvm_install.sh
      chmod +x $GITHUB_ACTION_PATH/llvm_install.sh
      if sudo $GITHUB_ACTION_PATH/llvm_install.sh 17; then
        sudo apt-get install -y clang-format-17 clang-tidy-17
      fi
    fi
  fi
  if [[ "Linux"  == "macOS" ]]; then
    python3 -m venv "$GITHUB_ACTION_PATH/venv"
    source "$GITHUB_ACTION_PATH/venv/bin/activate"
  fi
  python3 -m pip install -r "$GITHUB_ACTION_PATH/requirements.txt"
  clang-tools -i 17 -b
  shell: bash --noprofile --norc -e -o pipefail {0}
  env:
    GITHUB_TOKEN: ***
/__w/_temp/0cd2f190-16d6-4c82-aad3-0725a22ea861.sh: line 2: sudo: command not found
Error: Process completed with exit code 127.

---

To fix this, I would propose:

• We add sudo to the waybar:debian image
• We build a new container image specifically for configuring the project & running clang-tidy
• We manually install sudo in the clang-tidy.yml file, before running the clang-tidy step

What do you suggest?

[Alexays]

We can add sudo to images, Dockerfile are also stored in the repo, once changed i'll trigger a rebuild :)

[zjeffer]

I'm doing some manual tests by adding sudo and python3-pip (which also seems needed) in the yml file. I'll make a PR to change the Dockerfile once I've figured out how to fix the next errors I'm getting.