Fix clock on-scroll value not being used for calendar #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexays
reviewed
Mar 23, 2024
include/modules/clock.hpp
Outdated
| @@ -41,6 +41,7 @@ class Clock final : public ALabel { | |||
| const int cldMonColLen_{20}; // calendar month column length | |||
| WS cldWPos_{WS::HIDDEN}; // calendar week side to print | |||
| months cldCurrShift_{0}; // calendar months shift | |||
| int cldShift_{0}; // calendar months shift factor | |||
There was a problem hiding this comment.
Should not be set to 1 by default?
There was a problem hiding this comment.
If you look at the commit I listed, the code used to initialize this to 0, so I guess I just copied that.
The Wiki does say the default is 1, and that makes sense, so I can update that.
There was a problem hiding this comment.
Actually I don't think this matters much, because given the structure of the code right now, this functionality isn't enabled unless the user explicitly puts a value into their config file. So really this "default" is never used.
encbar5
force-pushed
the
restore_intertible_month_scroll
branch
from
09c0960
to
abd7ca2
Compare
|
LGTM, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of being able to invert the month scrolling in the calendar by setting "on-scroll" to -1 appears to have been broken in 86a3898.
This restores the ability to set the number of months that the scroll wheel scrolls, including negative numbers, as documented in the wiki https://github.com/Alexays/Waybar/wiki/Module:-Clock