add hide-empty-text option to hide module whenever output is empty but format is not #3395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am the original reporter, tested this on my install, can confirm this resolves my issue. |
|
LGTM, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3341
Custom module hides empty output, e.g. when a worker returns
{}as json. But when using other content in the format, e.g. to add an icon before or after output, it's no longer possible to have the module hidden.This PR addresses this by adding a config option
hide-empty-text, when true,text_is checked for empty rather thanstr.I realise I forgot the manpage, coming up in a second :P