AModule: Cursor config option #3398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To avoid yet another breaking change, I prefer to keep the cursor change logic but make it deactivatable in the settings. WDYT? |
Yeah, i actually agree. I was just waiting for some feedback before I changed it from the original change. I can tweak the change when I get home. |
|
@Alexays Alright, implemented fallback to default behavior when someone doesn't provide a configuration. |
Alexays
reviewed
Jul 3, 2024
also, statically configure the cursor type
|
@Alexays Sorry, fixed. Also noticed the mouse enter and leave were a breaking change with tool-tips so moved it back there for the default behavior when not configured. |
|
@Alexays Whenever you get a chance |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen a lot of discussion activity around this again... resurrecting the PR #3274 that resolves #3239. Follow up to work done in #3108 to make this opt in instead of always forced on users.
One thing that might be nice is to set a global option for this... but I didn't see a way of doing that easily, atm.