Use the same StatusNotifierWatcher for all trays #598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexays
reviewed
Feb 19, 2020
| @@ -23,6 +22,7 @@ Watcher::~Watcher() { | |||
| g_slist_free_full(items_, gfWatchFree); | |||
| items_ = nullptr; | |||
| } | |||
| Gio::DBus::unown_name(bus_name_id_); | |||
There was a problem hiding this comment.
It's not already the case when it's destroyed?
There was a problem hiding this comment.
Where is it destroyed ? I worked on the assumption that (bus_name_id_) is only an int, and therefore RAII does not apply.
There was a problem hiding this comment.
Ok you're right, I assumed that Gio::DBus::own_name will do it, but no.
Alexays
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
This uses a singleton so we only ever use one StatusNotifierWatcher for
all of our bars (and all of their trays).
Before we had one per tray module. The first one to get the DBus name
would prevent the others from getting it. When that tray disappears (due
to dpms toggles for example), the other watchers do not react to it
correctly. Plus, I am not even sure that it is correct for the same
process to try to acquire the same name multiple times.
This does not solve the fact that we should be able to lose the
name and get it back on the bus, but at least we are not deceiving
ourselves :).