river/tags: add module #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifreund
commented
Jun 12, 2020
Comment on lines
+173
to
+176
| if true | ||
| add_project_arguments('-DHAVE_RIVER', language: 'cpp') | ||
| src_files += 'src/modules/river/tags.cpp' | ||
| endif |
There was a problem hiding this comment.
this if true and the existence of the HAVE_RIVER define are pure cargo-culting, I just copied what is done for the wlr/taskbar module. The river/tags module does not introduce any external dependencies, it only requires wayland-scanner and the protocol xml which I have included in this PR.
|
Wouldn't be complete without a screenshot showing it off. |
|
Thanks @ifreund, I'd like to see other wlroots based compositors modules 😃 |
|
Sure! I should have time to add this to the wiki later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new module displaying the tags of river which serve a similar purpose to sway's workspaces. This works using a custom
river-statusprotocol that allows waybar to receive events when the tag state of an output changes.There are also other things that could be added to waybar for better integration with river such as a module displaying the title of the currently focused view, or a module displaying the current mode (like there is for sway already). I decided to implement the tags module first as it is the most important and I'm not totally sure what this project's stance is on supporting specific compositors other than sway.