Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update subprojects for date, gtk-layer-shell #797

Merged
merged 3 commits into from
Aug 5, 2020

Conversation

alebastr
Copy link
Contributor

@alebastr alebastr commented Aug 5, 2020

Fixes: #776, fixes #780 (via date 3.0.0)
Fixes: #530, fixes #750 (via gtk-layer-shell 0.2.0)


gtk-layer-shell will now print a harmless warning about xdg-wm-base version mismatch. This is caused by gtk-layer-shell bundling xdg-shell protocol of older version, which I'll try to fix upstream before upcoming 0.2.1 release.

CI is not using gtk-layer-shell subproject:

|subprojects/gtk-layer-shell-0.2.0/src/meson.build:24:0: Exception: Static libraries can only be introspected with GObject-Introspection >=1.58.1
...
    gtk-layer-shell: NO Static libraries can only be introspected with GObject-Introspection >=1.58.1

Sounds like missing dependency in docker files.

Statically linked gtk-layer-shell would use layer-shell protocol object
file from waybar and print runtime warning if the version does not match
@Alexays
Copy link
Owner

Alexays commented Aug 5, 2020

Nice, thanks!

@Alexays Alexays merged commit 7d5da1d into Alexays:master Aug 5, 2020
@Alexays
Copy link
Owner

Alexays commented Aug 5, 2020

Fixed the CI for archlinux and debian, gtk-layer-shell is now properly used.

@alebastr alebastr deleted the update-subprojects branch August 9, 2020 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants