Fix issues in wlr/taskbar #969
Conversation
wl_array->size contains the number of bytes in the array instead of the number of elements.
Destroy request is not specified for foreign toplevel manager and it does not prevent the compositor from sending more events. Libwayland would ignore events to a destroyed objects, but that could indirectly cause a gap in the sequence of new object ids and trigger error condition in the library. With this commit waybar sends a `stop` request to notify the compositor about the destruction of a toplevel manager. That fixes abnormal termination of the bar with following errors: ``` (waybar:11791): Gdk-DEBUG: 20:04:19.778: not a valid new object id (4278190088), message toplevel(n) Gdk-Message: 20:04:19.778: Error reading events from display: Invalid argument ```
|
Thank you very much for your fixes. All looks good to me. |
|
LGTM |
|
Hm, I get now some very wired behavior when unplugging from an external output. Sometimes my compositor (wayfire) crashes now which is even worse than waybar crashing. But I first need to look into this more closely. |
|
@l3nkz do you have a wayfire backtrace? |
|
@alebastr I am working on it. However, I couldn't yet reproduce it when I start wayfire directly from console instead of starting it via SDDM. I will continue digging into the problem. Maybe this is unrelated with this change. I will keep you updated. |
|
After some more digging, I think this is actually unrelated to your change. Thank you again for your work. |
See commit descriptions for individual issues.
A better fix for the protocol error would be to separate the foreign toplevel manager code from Gtk UI and keep a single instance shared between bars, but that requires more time and effort than I can spare right now☹️
CC: @danieldg, @l3nkz