Don't extern alloc unless needed to avoid requiring global allocators in #[no_std] environments #108
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling the
std
feature causesextern crate alloc
to be used, which in turn requires any downstream#[no_std]
users to define a global allocator with a message like this:This change ensures that we only use
extern crate alloc
when it's actually needed, which is when thewrite
feature is enabled.Also note that
std::string::String
andstd::vec::Vec
are aliases for the correspondingalloc
types, so importing it throughstd
when it's available is not necessary.It would arguably be cleaner for
#![no_std]
to always be enabled and add the following wherestd
types and items are used, but changing this is up to you: