Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically check for (unintended) dll dependencies #1321

Merged
merged 2 commits into from
Jun 26, 2018
Merged

Automatically check for (unintended) dll dependencies #1321

merged 2 commits into from
Jun 26, 2018

Conversation

jeroen
Copy link
Contributor

@jeroen jeroen commented Jun 26, 2018

A little script that shows dll dependencies in the CI script. This way we can manually inspect if there are any unlisted msys2 dependencies.

I modified the curl PKGBUILD only for testing this script :) We don't have to merge that part.

@Alexpux Alexpux merged commit 31d4ce1 into msys2:master Jun 26, 2018
@jeroen jeroen deleted the dllscript branch June 26, 2018 12:54
@peterbud
Copy link
Contributor

Is there any way to prevent failing the build script in case there is no dll/exe in the package? Right now all perl package builds fail as ther is no dll or exe in the package:

MSYS2 DLL dependencies:
ldd: missing file arguments
Try `ldd --help' for more information.
[MSYS2 CI] FAILURE: perl-URI: Checking dll depencencies failed.
Command exited with code 1

@jeroen
Copy link
Contributor Author

jeroen commented Jul 16, 2018

Ah sorry about that. I'll try to fix that!

@jeroen
Copy link
Contributor Author

jeroen commented Jul 16, 2018

OK I sent a PR: #1348

@niklasholm
Copy link
Contributor

Did you test this? Looks to me it still fails since the function "inherits" the status code of the last command, which is still falsy. Fix in #1379.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants