Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove explicit dependence on S3 #78

Closed
jashapiro opened this issue Jan 27, 2022 · 0 comments · Fixed by #83
Closed

Remove explicit dependence on S3 #78

jashapiro opened this issue Jan 27, 2022 · 0 comments · Fixed by #83
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jashapiro
Copy link
Member

As discussed in https://github.com/AlexsLemonade/ScPCA-admin/issues/298, the current metadata file that we use as the control list for this workflow, defined in params.run_metafile, assumes that certain files are on S3. When we make that explicit (allowing for files to be stored on other services or locally), we should adjust the workflow to use the urls as specified, not adding s3:// as we currently do, for example at

scpca-nf/modules/af-rna.nf

Lines 99 to 102 in bc587b5

.map{meta -> tuple(meta,
file("s3://${meta.s3_prefix}/*_R1_*.fastq.gz"),
file("s3://${meta.s3_prefix}/*_R2_*.fastq.gz")
)}

Note that if we changed the name of the s3_prefix field while accomplishing https://github.com/AlexsLemonade/ScPCA-admin/issues/298, this will also need to be updated.

@jashapiro jashapiro added enhancement New feature or request good first issue Good for newcomers labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant