-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(docker): update Dockerfiles to use ENTRYPOINT instead of CMD #1016
Open
skrashevich
wants to merge
7
commits into
AlexxIT:master
Choose a base branch
from
skrashevich:docker-improv
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Mar 22, 2024
-
feat(docker): update Docker syntax, add entrypoint script, and ensure…
… cross-platform compatibility - Updated Dockerfile and hardware.Dockerfile syntax to `docker/dockerfile:1.4` for enhanced features and performance. - Introduced `--link` option in COPY commands to optimize layer caching and reduce image size. - Added a new `entrypoint.sh` script for dynamic configuration and validation of environment variables, improving container startup flexibility. - Included `yq` utility in the base images to facilitate YAML file manipulation within the container, enhancing configuration management capabilities. - Specified `--platform=linux/amd64` for base images to ensure consistent cross-platform builds, addressing potential compatibility issues on multi-architecture setups. - Modified ENTRYPOINT to utilize the new entrypoint script, enabling pre-execution configuration checks and setting a default configuration if none is provided. - The addition of `yq` and changes to the entrypoint mechanism provide a more robust and user-friendly setup process, potentially affecting existing workflows that rely on manual configuration file adjustments. These changes aim to improve maintainability, efficiency, and user experience by leveraging newer Docker features, automating configuration tasks, and ensuring broader compatibility across different computing environments.
Configuration menu - View commit details
-
Copy full SHA for 7e0411f - Browse repository at this point
Copy the full SHA 7e0411fView commit details
Commits on Apr 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0035784 - Browse repository at this point
Copy the full SHA 0035784View commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 12d8d1d - Browse repository at this point
Copy the full SHA 12d8d1dView commit details
Commits on May 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3ab93fc - Browse repository at this point
Copy the full SHA 3ab93fcView commit details -
refactor(docker): remove yq dependency and simplify config creation
- Removed `yq` installation from Dockerfile to reduce image size. - Simplified default configuration file creation in entrypoint.sh by directly writing YAML content, eliminating the need for `yq`. - Removed `yq` installation step from hardware.Dockerfile and adjusted file copying accordingly.
Configuration menu - View commit details
-
Copy full SHA for 85392fc - Browse repository at this point
Copy the full SHA 85392fcView commit details -
fix(entrypoint): streamline config initialization and execution
Simplify the entrypoint script by removing the creation of a default configuration file if it doesn't exist. Instead, directly pass the default API listen port configuration to the `go2rtc` command, while still allowing custom configurations through the existing `CONFIG_PATH`. This change ensures that the service can start with default settings without needing to write them to a file, simplifying deployment and configuration management.
Configuration menu - View commit details
-
Copy full SHA for 8840a18 - Browse repository at this point
Copy the full SHA 8840a18View commit details
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1e13d20 - Browse repository at this point
Copy the full SHA 1e13d20View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.