Add POC for code execution #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, why would you want to make a malicious file with this? If that's not the intent, can you name the function and argument help something else? |
|
@AlfredoSequeida Do you think this violates the GitHub TOS in that it allows for creating malicious files, or do you think this is okay to merge? |
|
It's just a proof of concept. |
|
Then why make it a pull request here? |
|
I just wanted to show that it's vulnerable and you should be careful |
|
Yeah I have seen this come up before and I can kind of understand the concern. If I get some time I'll try to look into what we can do about that. If anyone has any suggestions regarding this issue I'm open to hearing them. |
|
#35 I made an issue for this if anyone wants to help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not that smart to use pickle for saving data. I included a new command which shows that you can include your own code in an encoded file.
Have fun with it!