[ACS-4536] deprecate and cleanup aca-settings module (#2978)

.github/workflows/test.yml

@@ -95,24 +95,6 @@ jobs:
       - run: npm ci
       - run: npm test aca-shared -- --browsers=ChromeHeadless --watch=false $TEST_OPTS
 
-  test-aca-settings:
-    needs: [lint, build]
-    name: 'test: aca-settings'
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v3
-        with:
-          fetch-depth: 2
-
-      - name: node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 14
-          cache: 'npm'
-      - run: npm ci
-      - run: npm test aca-settings -- --browsers=ChromeHeadless --watch=false $TEST_OPTS
-
   test-aca-folder-rules:
     needs: [lint, build]
     name: 'test: aca-folder-rules'

angular.json

@@ -92,11 +92,6 @@
                 "input": "projects/aca-about/assets",
                 "output": "./assets/plugins"
               },
-              {
-                "glob": "settings.plugin.json",
-                "input": "projects/aca-settings/assets",
-                "output": "./assets/plugins"
-              },
               {
                 "glob": "folder-rules.plugin.json",
                 "input": "projects/aca-folder-rules/assets",
@@ -515,52 +510,6 @@
         }
       }
     },
-    "aca-settings": {
-      "projectType": "library",
-      "root": "projects/aca-settings",
-      "sourceRoot": "projects/aca-settings/src",
-      "prefix": "lib",
-      "architect": {
-        "build": {
-          "builder": "@angular-devkit/build-angular:ng-packagr",
-          "options": {
-            "tsConfig": "projects/aca-settings/tsconfig.lib.json",
-            "project": "projects/aca-settings/ng-package.json"
-          },
-          "configurations": {
-            "production": {
-              "tsConfig": "projects/aca-settings/tsconfig.lib.prod.json"
-            }
-          },
-          "defaultConfiguration": "production"
-        },
-        "test": {
-          "builder": "@angular-devkit/build-angular:karma",
-          "options": {
-            "main": "projects/aca-settings/src/test.ts",
-            "tsConfig": "projects/aca-settings/tsconfig.spec.json",
-            "karmaConfig": "projects/aca-settings/karma.conf.js"
-          },
-          "configurations": {
-            "adfprod": {
-              "tsConfig": "projects/aca-settings/tsconfig.spec.adf.json"
-            }
-          }
-        },
-        "lint": {
-          "builder": "@angular-eslint/builder:lint",
-          "options": {
-            "lintFilePatterns": [
-              "projects/aca-settings/**/*.ts",
-              "projects/aca-settings/**/*.html"
-            ],
-            "cache": true,
-            "cacheLocation": ".eslintcache",
-            "ignorePath": ".eslintignore"
-          }
-        }
-      }
-    },
     "aca-folder-rules": {
       "projectType": "library",
       "root": "projects/aca-folder-rules",

app/src/app/extensions.module.ts

@@ -26,17 +26,11 @@
 import { NgModule } from '@angular/core';
 import { AosExtensionModule } from '@alfresco/adf-office-services-ext';
 import { AcaAboutModule } from '@alfresco/aca-about';
-import { AcaSettingsModule } from '@alfresco/aca-settings';
 import { AcaFolderRulesModule } from '@alfresco/aca-folder-rules';
 import { environment } from '../environments/environment';
 import packageJson from 'package.json';
 
 @NgModule({
-  imports: [
-    AosExtensionModule,
-    ...(environment.devTools ? [AcaSettingsModule] : []),
-    AcaAboutModule.forRoot(environment.production, packageJson),
-    AcaFolderRulesModule
-  ]
+  imports: [AosExtensionModule, AcaAboutModule.forRoot(environment.production, packageJson), AcaFolderRulesModule]
 })
 export class AppExtensionsModule {}

package.json

@@ -14,7 +14,7 @@
     "prebuild": "mkdir -p ./app/.tmp && cp ./app/src/app.config.json.tpl ./app/.tmp/app.config.json",
     "build": "ng build content-ce",
     "build.release": "npm run build -- --configuration=production,release",
-    "build-libs": "ng build aca-shared && ng build adf-office-services-ext && ng build aca-settings && ng build aca-about && ng build aca-viewer && ng build aca-preview && ng build aca-folder-rules && ng build aca-content",
+    "build-libs": "ng build aca-shared && ng build adf-office-services-ext && ng build aca-about && ng build aca-viewer && ng build aca-preview && ng build aca-folder-rules && ng build aca-content",
     "test": "ng test",
     "test:ci": "ng test adf-office-services-ext && ng test content-ce --code-coverage",
     "lint": "NODE_OPTIONS=--max_old_space_size=4096 ng lint && npm run spellcheck && npm run e2e.typecheck",

projects/aca-preview/karma.conf.js

@@ -16,7 +16,7 @@ module.exports = function (config) {
       clearContext: false // leave Jasmine Spec Runner output visible in browser
     },
     coverageIstanbulReporter: {
-      dir: require('path').join(__dirname, '../../coverage/aca-settings'),
+      dir: require('path').join(__dirname, '../../coverage/aca-preview'),
       reports: ['html', 'lcovonly', 'text-summary'],
       fixWebpackSourcePaths: true
     },