[ACA-4715] break dependency on envsubst (#3325)

* remove BPM host

* break dependency on envsubst

* remove prebuild script

* cleanup package.json

.github/actions/before-e2e/action.yml

@@ -32,7 +32,7 @@ runs:
   steps:
     - name: Check content UP
       shell: bash
-      run: ./node_modules/@alfresco/adf-cli/bin/adf-cli check-cs-env --host $APP_CONFIG_ECM_HOST -u $ADMIN_EMAIL -p $ADMIN_PASSWORD || exit 1
+      run: ./node_modules/@alfresco/adf-cli/bin/adf-cli check-cs-env --host $BASE_URL -u $ADMIN_EMAIL -p $ADMIN_PASSWORD || exit 1
 
     - name: Download artifacts
       uses: ./.github/actions/download-job-artifact
@@ -43,18 +43,6 @@ runs:
         aws-secret-access-key: ${{ inputs.aws-secret-access-key }}
         aws-region: ${{ inputs.aws-region }}
 
-    - name: Replace variables in app.config.json
-      shell: bash
-      run: |
-        APP_CONFIG_FILE_PATH="${{ inputs.to }}/app.config.json"
-        npx envsub --all $APP_CONFIG_FILE_PATH $APP_CONFIG_FILE_PATH || exit 1
-        echo  -n "     \_ Validating replaced config file ... ";
-        npx ajv validate -s ./node_modules/@alfresco/adf-core/app.config.schema.json -d $APP_CONFIG_FILE_PATH --errors=text --verbose || exit 4
-        if grep -E -q '\$\{[A-Z0-9_]*\}' $APP_CONFIG_FILE_PATH; then
-            echo -e "\e[31m        \_ ERROR: Variables are still present in the app.config.json file. Some of them might not have default value set.\e[0m";
-            exit 5;
-        fi
-
     - name: Update webdriver-manager
       shell: bash
       run: |

.github/actions/run-e2e-playwright/action.yml

@@ -22,12 +22,6 @@ runs:
     - name: Setup and run with options
       shell: bash
       run: |
-        # npx http-server -c-1 $CONTENT_CE_DIST_PATH -p 4200 > /dev/null &\
-
-        {
-          echo "APP_CONFIG_ECM_HOST={protocol}//{hostname}{:port}"
-        } >> .env
-
         npm start > /dev/null &\
 
         echo "Running playwright tests with options ${{ inputs.options }}"

.github/actions/run-e2e/action.yml

@@ -23,12 +23,6 @@ runs:
       shell: bash
       run: |
         ./node_modules/.bin/tsc -p "./e2e/protractor/$E2E_TSCONFIG" || exit 1;
-        # npx http-server -c-1 $CONTENT_CE_DIST_PATH -p 4200 > /dev/null &\
-
-        {
-          echo "APP_CONFIG_ECM_HOST={protocol}//{hostname}{:port}"
-        } >> .env
-
         npm start > /dev/null &\
 
         if [ ${{ inputs.test-runner }} == "playwright" ]; then

.github/workflows/pull-request.yml

@@ -10,7 +10,7 @@ concurrency:
   cancel-in-progress: true
 
 env:
-  APP_CONFIG_ECM_HOST: ${{ secrets.PIPELINE_ENV_URL }}
+  BASE_URL: ${{ secrets.PIPELINE_ENV_URL }}
   ADMIN_EMAIL: ${{ secrets.PIPELINE_ADMIN_USERNAME }}
   ADMIN_PASSWORD: ${{ secrets.PIPELINE_ADMIN_PASSWORD }}
   HR_USER: ${{ secrets.HR_USER }}

.github/workflows/release.yml

@@ -14,15 +14,14 @@ on:
       - develop
 
 env:
-  APP_CONFIG_ECM_HOST: ${{ secrets.PIPELINE_ENV_URL }}
+  BASE_URL: ${{ secrets.PIPELINE_ENV_URL }}
   ADMIN_EMAIL: ${{ secrets.PIPELINE_ADMIN_USERNAME }}
   ADMIN_PASSWORD: ${{ secrets.PIPELINE_ADMIN_PASSWORD }}
   AWS_REGION: "eu-west-2"
   CONTENT_CE_DIST_PATH: "./dist/content-ce"
   PLAYWRIGHT_E2E_HOST: ${{ secrets.PLAYWRIGHT_E2E_HOST }}
   NPM_REGISTRY_ADDRESS: ${{ secrets.NPM_REGISTRY_ADDRESS }}
 
-
 jobs:
   publish-docker-registry:
     name: "Publish to Quay"

Dockerfile

@@ -18,9 +18,6 @@ USER 101
 
 ARG PROJECT_NAME
 
-ENV APP_CONFIG_BPM_HOST="{protocol}//{hostname}{:port}"
-ENV APP_CONFIG_ECM_HOST="{protocol}//{hostname}{:port}"
-
 COPY docker/default.conf.template /etc/nginx/templates/
 
 COPY dist/$PROJECT_NAME /usr/share/nginx/html/

README.md

@@ -25,7 +25,7 @@ Please refer to the public [documentation](https://alfresco-content-app.netlify.
 Create an `.env` file in the project root folder with the following content
 
 ```yml
-APP_CONFIG_ECM_HOST="<URL>"
+BASE_URL="<URL>"
 ```
 
 Where `<URL>` is the address of the ACS.

app/project.json

@@ -33,9 +33,9 @@
           "app/src/assets",
           "app/src/favicon-96x96.png",
           {
-            "input": "app/.tmp",
-            "output": "/",
-            "glob": "app.config.json"
+            "glob": "app.config.json",
+            "input": "app/src",
+            "output": "/"
           },
           {
             "glob": "**/*",

app/proxy.conf.js

@@ -1,10 +1,10 @@
 require('@alfresco/adf-cli/tooling').dotenvConfig({ path: process.env.ENV_FILE });
 
-const APP_CONFIG_ECM_HOST = process.env.APP_CONFIG_ECM_HOST;
+const { BASE_URL } = process.env;
 
 module.exports = {
     "/alfresco": {
-        "target": APP_CONFIG_ECM_HOST,
+        "target": BASE_URL,
         "secure": false,
         "pathRewrite": {
             "^/alfresco/alfresco": ""
@@ -13,7 +13,7 @@ module.exports = {
         'logLevel': 'debug',
         onProxyReq: function(request) {
           if(request["method"] !== "GET")
-          request.setHeader("origin", APP_CONFIG_ECM_HOST);
+          request.setHeader("origin", BASE_URL);
         },
         // workaround for REPO-2260
         onProxyRes: function (proxyRes) {

app/src/app.config.json.tpl → app/src/app.config.json

@@ -1,8 +1,8 @@
 {
   "$schema": "../node_modules/@alfresco/adf-core/app.config.schema.json",
-  "ecmHost": "${APP_CONFIG_ECM_HOST}",
-  "aosHost": "${APP_CONFIG_ECM_HOST}/alfresco/aos",
-  "baseShareUrl": "${APP_CONFIG_ECM_HOST}/#/preview/s",
+  "ecmHost": "{protocol}//{hostname}{:port}",
+  "aosHost": "{protocol}//{hostname}{:port}/alfresco/aos",
+  "baseShareUrl": "{protocol}//{hostname}{:port}/#/preview/s",
   "providers": "ECM",
   "authType": "BASIC",
   "loginRoute": "login",

docker/run.sh

@@ -3,10 +3,6 @@
 set -e
 
 eval ALL_ARGUMENTS=("BASE_PATH"
-    "APP_BASE_SHARE_URL"
-    "APP_CONFIG_IDENTITY_HOST"
-    "APP_CONFIG_BPM_HOST"
-    "APP_CONFIG_ECM_HOST"
 )
 ALL_ARGUMENTS_LENGTH=${#ALL_ARGUMENTS[@]}
 DOCKER_ARGS=""

docs/getting-started/building-from-source.md

@@ -34,7 +34,7 @@ You need to set some environment variables to be able to run the local dev serve
 
 ```yml
 # App config settings
-APP_CONFIG_ECM_HOST="<URL>"
+BASE_URL="<URL>"
 ```
 
 ## Proxy settings