Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

Revert changes added with #65 unless activiti provides new enterprise endpoint #217

Closed
VitoAlbano opened this issue Apr 11, 2017 · 10 comments
Assignees
Milestone

Comments

@VitoAlbano
Copy link
Contributor

Type of issue: (check with "[x]")

- [ ] New feature request
- [x ] Bug  
- [ ] Support request

Current behavior:
On completed task the call for task/variables fail cause it works only for running tasks

Expected behavior:
task variables should be retrieved even on completed forms.

Steps to reproduce the issue:

Node version (for build issues):

New feature request:

@VitoAlbano VitoAlbano self-assigned this Apr 11, 2017
VitoAlbano added a commit that referenced this issue Apr 11, 2017
VitoAlbano added a commit that referenced this issue Apr 12, 2017
eromano pushed a commit that referenced this issue Apr 12, 2017
* #217 - revert changes from #65

* fix wrongly changed date on changelog
@eromano eromano added this to the 1.3.1 milestone Apr 12, 2017
@tdonovancsra
Copy link

tdonovancsra commented Apr 12, 2017

please fix +1
I hope revert doesn't mean to put it back the way it was! We need this to be fixed

@eromano
Copy link
Contributor

eromano commented Apr 12, 2017

@tdonovancsra I reopened the #199. This api will be probably released in the version 16.1 or 1.6.2 of activiti. we will wait before the release of this fix before to reintroduce it

@tdonovancsra
Copy link

so does that mean the call goes back to the REST api?

@eromano
Copy link
Contributor

eromano commented Apr 12, 2017

sorry @tdonovancsra wich is the problem that you are experiencing as far as I know this modify should not affect any functionality is change a change of the api between the public and the private

@tdonovancsra
Copy link

tdonovancsra commented Apr 12, 2017

on completed cases I am receiving 404 not found when it makes the call to get the variables

/api/enterprise/tasks/{}/variables

or is this not the problem the bug describes?

@tdonovancsra
Copy link

is there a workaround until 1.6.2?

@eromano
Copy link
Contributor

eromano commented Apr 12, 2017

@tdonovancsra this PR is about to change this endpoint that is not implemented yet in the public side with the private that works:

'/app/rest/task-forms/{taskId}/variables'

@tdonovancsra
Copy link

I'm going to have to override that method we can't wait that long. If you switch it back it messes up the authentication scheme. You should consider a different solution

@eromano
Copy link
Contributor

eromano commented Apr 12, 2017

@tdonovancsra sorry I don't get your point maybe I don't know enough about your scenario.
The alfresco.js-api 1.2 was already working like that using '/app/rest/task-forms/{taskId}/variables' and there are no problems about auth as far as I know.

@tdonovancsra
Copy link

yeah I voted for #199 because of this issue. that call was not working for us. We are using basic authentication to get to the backend and the /rest/ endpoint for the angular 1 app uses cookies. That call fails for our scenario.

@eromano eromano modified the milestones: 1.3.1, 1.4.0 Apr 21, 2017
@eromano eromano mentioned this issue Apr 26, 2017
eromano pushed a commit that referenced this issue Apr 26, 2017
* #217 - revert changes from #65

* fix wrongly changed date on changelog
magemello pushed a commit that referenced this issue Apr 27, 2017
* #217 - revert changes from #65

* fix wrongly changed date on changelog
@eromano eromano closed this as completed Apr 27, 2017
eromano pushed a commit that referenced this issue May 26, 2017
* #217 - revert changes from #65

* fix wrongly changed date on changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants