Skip to content
This repository has been archived by the owner on Feb 8, 2024. It is now read-only.

[ACS-4331] Add deleteTag method to tags API #1490

Merged
merged 6 commits into from
Feb 14, 2023

Conversation

nikita-web-ua
Copy link
Contributor

Please check if the PR fulfills these requirements

[X] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-js-api/wiki/Commit-format)
[ ] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[X] Documentation
[ ] Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

We don't currently have a method to completely remove a tag.
https://alfresco.atlassian.net/browse/ACS-4331

What is the new behavior?

deleteTag() method has been added

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[X] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@nikita-web-ua nikita-web-ua marked this pull request as draft January 11, 2023 13:42
@nikita-web-ua nikita-web-ua changed the title [ACS-4331] Add delete a tag method to tags api [ACS-4331] Add deleteTag method to tags API Jan 11, 2023
@DenysVuika
Copy link
Contributor

needs rebase

@DenysVuika
Copy link
Contributor

@nikita-web-ua is this PR still actual?

@nikita-web-ua
Copy link
Contributor Author

@nikita-web-ua is this PR still actual?

@DenysVuika yes it is, waiting for BE.

@nikita-web-ua nikita-web-ua force-pushed the dev-mmaliarchuk/ACS-4331-delete-tag branch from 733946f to 9f190c8 Compare February 14, 2023 13:32
@nikita-web-ua nikita-web-ua marked this pull request as ready for review February 14, 2023 13:33
@DenysVuika DenysVuika merged commit 4152c12 into develop Feb 14, 2023
@DenysVuika DenysVuika deleted the dev-mmaliarchuk/ACS-4331-delete-tag branch February 14, 2023 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants